Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Warning: Package 'faster _whisper.assets' is absent from the packages configuration. #772

Closed
otakutyrant opened this issue Apr 1, 2024 · 3 comments

Comments

@otakutyrant
Copy link
Contributor

I was trying to package faster-whiser in Arch Linux. But in building the package, it warned:

...
/usr/lib/python3.11/site-packages/setuptools/command/build_py.py:207: _Warning: Package 'faster_whisper.assets' is absent from the `packages` configuration.
!!

        ********************************************************************************
        ############################
        # Package would be ignored #
        ############################
        Python recognizes 'faster_whisper.assets' as an importable package[^1],
        but it is absent from setuptools' `packages` configuration.

        This leads to an ambiguous overall configuration. If you want to distribute this
        package, please make sure that 'faster_whisper.assets' is explicitly added
        to the `packages` configuration field.

        Alternatively, you can also rely on setuptools' discovery methods
        (for example by using `find_namespace_packages(...)`/`find_namespace:`
        instead of `find_packages(...)`/`find:`).

        You can read more about "package discovery" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html

        If you don't want 'faster_whisper.assets' to be distributed and are
        already explicitly excluding 'faster_whisper.assets' via
        `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,
        you can try to use `exclude_package_data`, or `include-package-data=False` in
        combination with a more fine grained `package-data` configuration.

        You can read more about "package data files" on setuptools documentation page:

        - https://setuptools.pypa.io/en/latest/userguide/datafiles.html


        [^1]: For Python, any directory (with suitable naming) can be imported,
              even if it does not contain any `.py` files.
              On the other hand, currently there is no concept of package data
              directory, all directories are treated like packages.
        ********************************************************************************
...
@trungkienbkhn
Copy link
Collaborator

@otakutyrant , Could you find this line in your log?
copying build/lib/faster_whisper/assets/silero_vad.onnx -> build/bdist.linux-x86_64/egg/faster_whisper/assets
If it exists, I think the fw is built okay.
You can try to test the newly built package and report if it causes any error.

@otakutyrant
Copy link
Contributor Author

Hello, there was a line: copying build/lib/faster_whisper/assets/silero_vad.onnx -> /home/otakutyrant/Projects/whisper/pkg/python-faster-whisper/usr/lib/python3.11/site-packages/faster_whisper/assets. I know the warning is just a warning, and I built the package successfully.

I will make a PR to solve the issue if you agree.

@trungkienbkhn
Copy link
Collaborator

trungkienbkhn commented Apr 1, 2024

@otakutyrant Feel free to open a new PR if needed 😃

otakutyrant added a commit to otakutyrant/faster-whisper that referenced this issue Apr 1, 2024
faster_whisper use `find_packages` in setup.py to scan directories and
distribute valid python packages. According to
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html,
the `find_packages` function will ignore `faster_whisper/assets` which
is not a valid python package because it does not contain `__init__.py`.

However, when I build the package, setuptools raise a waring as SYSTRAN#772,
and I do not know why. So I add `__init__.py` under the
`faster_whisper.assets` directory, making setuptools regard
`faster_whisper.assets` is a part of distribution.
otakutyrant added a commit to otakutyrant/faster-whisper that referenced this issue Apr 1, 2024
…YSTRAN#772)

faster_whisper use `find_packages` in setup.py to scan directories and
distribute valid python packages. According to
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html,
the `find_packages` function will ignore `faster_whisper/assets` which
is not a valid python package because it does not contain `__init__.py`.

However, when I build the package, setuptools raise a waring as SYSTRAN#772,
and I do not know why. So I add `__init__.py` under the
`faster_whisper.assets` directory, making setuptools regard
`faster_whisper.assets` is a part of distribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants