Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update audio.py #1091

Closed
wants to merge 2 commits into from
Closed

Update audio.py #1091

wants to merge 2 commits into from

Conversation

BBC-Esq
Copy link
Contributor

@BBC-Esq BBC-Esq commented Oct 25, 2024

Utilize NumPy's optimized array concatenation (np.concatenate), which is faster and more memory-efficient.

@MahmoudAshraf97
Copy link
Collaborator

Hi,
The CI tests are failing due to formatting errors and functional errors
you can follow the Contributing Guideline to run tests locally and make sure they pass.

Also can you provide simple benchmark numbers before and after this change, maybe including loading time and memory consumption for several audio lengths

@BBC-Esq BBC-Esq closed this Oct 27, 2024
@BBC-Esq BBC-Esq deleted the audio branch October 27, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BBC-Esq @MahmoudAshraf97