update: Ensure method _asdict
also converts Word object into a native dict
#667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after segments are generated with the
WhiperModel.transcribe()
method andword_timestamps=True
, upon using methodSegment()._asdict
, we get output like the following:In the image above, the upper red box is undesired, because
_asdict
should convert to native types. Additionally, this causes information, such as the dictionary keys are also lost when we convert the object that is supposedly adict
usingjson.dumps
as exemplified in the lower red box.The change presented therefore ensures that all
Word()
objects are first converted to native types, so that the keys for eachWord()
are retained when the_asdict
method is called, orjson.dumps(segment._asdict())
is called.