Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vless inbound mux disable has no effect #2415

Open
5 tasks done
markpash opened this issue Dec 28, 2024 · 3 comments
Open
5 tasks done

vless inbound mux disable has no effect #2415

markpash opened this issue Dec 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@markpash
Copy link

Operating system

Linux

System version

NixOS

Installation type

Others

If you are using a graphical client, please provide the version of the client.

No response

Version

I use 1.10.5 with slight changes for debug logging and metrics to diagnose resource leaks

Description

When running a vless inbound, the mux enable/disable setting has no effect, the mux codepath in sing-vmess is still executed even when disabled in config.

Reproduction

{
  "inbounds": [
    {
      "listen": "0.0.0.0",
      "listen_port": 443,
      "multiplex": {
        "enabled": false,
        "padding": false
      },
      "tag": "vless",
      "tcp_fast_open": true,
      "tcp_multi_path": false,
      "type": "vless",
      "users": [
        {
          "flow": "",
          "name": "a",
          "uuid": "957fca0e-1fd3-44f7-87f5-a4364209bb78"
        }
      ]
    }
  ],
  "log": {
    "disabled": false,
    "level": "debug",
    "timestamp": false
  },
  "outbounds": [
    {
      "tag": "direct",
      "type": "direct"
    }
  ],
  "route": {
    "final": "direct"
  }
}

With the above server config, this code in sing-vmess is still executed when a client enables mux.

Logs

No response

Supporter

Integrity requirements

  • I confirm that I have read the documentation, understand the meaning of all the configuration items I wrote, and did not pile up seemingly useful options or default values.
  • I confirm that I have provided the server and client configuration files and process that can be reproduced locally, instead of a complicated client configuration file that has been stripped of sensitive data.
  • I confirm that I have provided the simplest configuration that can be used to reproduce the error I reported, instead of depending on remote servers, TUN, graphical interface clients, or other closed-source software.
  • I confirm that I have provided the complete configuration files and logs, rather than just providing parts I think are useful out of confidence in my own intelligence.
@nekohasekai nekohasekai added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 29, 2024
@nekohasekai
Copy link
Member

multiplex in sing-box only controls sing-mux multiplexing protocol, Mux.Cool in vmess/vless is part of its protocol and cannot be disabled.

I suggest you switch to trojan, or I will add a new option to disable Mux.Cool in vmess/vless if you like.

@markpash
Copy link
Author

multiplex in sing-box only controls sing-mux multiplexing protocol, Mux.Cool in vmess/vless is part of its protocol and cannot be disabled.

I suggest you switch to trojan, or I will add a new option to disable Mux.Cool in vmess/vless if you like.

I see, in that case I don't really need new options, perhaps just a note in the docs to explain what you've just written here.

@markpash
Copy link
Author

followup issue with real bug #2421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants