Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint mixed. #29

Closed
vzikmund opened this issue Mar 2, 2023 · 4 comments
Closed

Type hint mixed. #29

vzikmund opened this issue Mar 2, 2023 · 4 comments

Comments

@vzikmund
Copy link

vzikmund commented Mar 2, 2023

Hi,
I am using your package (version 3.1.3) which should be able to run on php 7.4 according to your docs and composer.json php: >=7.4.0.

However in the file Tool.php you are using mixed type hint, which was introduced in PHP 8.0 (https://php.watch/versions/8.0/mixed-type)

public static function convertToString(mixed $input): string

Is this a bug or feature? 🙃

@dasim
Copy link

dasim commented Mar 2, 2023

Same problem here, running it on PHP 7.4 raises this problem.
Argument 1 passed to Salamek\Zasilkovna\Tool::convertToString must be an instance of Salamek\Zasilkovna\mixed, null given

@Salamek Salamek closed this as completed in 506e9be Mar 2, 2023
@Salamek
Copy link
Owner

Salamek commented Mar 2, 2023

Ok ok!, i have removed that in 3.1.4, but the second Debian 12 is released as stable, i'm flooding this project with PHP 8.1 stuff lol

@vzikmund
Copy link
Author

vzikmund commented Mar 3, 2023

Wow. Thank you for such a prompt fix 🙏

@dasim
Copy link

dasim commented Mar 3, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants