Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider: dynamic time format config flag #63

Closed
ctlaltdefeat opened this issue Oct 20, 2024 · 3 comments · Fixed by #67
Closed

Consider: dynamic time format config flag #63

ctlaltdefeat opened this issue Oct 20, 2024 · 3 comments · Fixed by #67
Labels
feature request New feature or request

Comments

@ctlaltdefeat
Copy link

Dynamic time format was added in #50, but some users (me) may not prefer it (confusing at a glance whether a video is 2 minutes or 2 hours long, too used to the old format, etc..).

Perhaps adjustable via config?

@Samillion
Copy link
Owner

Noted. @Xurdejl would you like me to add this as user_opts or do you want to do it?

timestamp_mode = "dynamic",                   -- accepts dynamic, static. (static is default mpv timestamp)

@Samillion Samillion added the feature request New feature or request label Oct 20, 2024
@Xurdejl
Copy link
Contributor

Xurdejl commented Oct 20, 2024

The leading '00:' felt more like a bug than an intentional design choice since it doesn’t really provide any benefits, just clutter. That’s why I didn’t add an option to display it the old way in the first place. But sure, I can add it as an option

@Samillion
Copy link
Owner

The leading '00:' felt more like a bug than an intentional design choice since it doesn’t really provide any benefits, just clutter. That’s why I didn’t add an option to display it the old way in the first place. But sure, I can add it as an option

I honestly agree. Since your PR, timestamp has made more sense to me. In fact, one of the first things we learn about elements is only use space you actually need. and the HH in a none HH file/seek is definitely wasted space.

But preference and old habits die hard. An option to toggle it off (on by default) will satisfy everyone.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants