Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mpv title-bar option #72

Closed
Keith94 opened this issue Oct 21, 2024 · 4 comments · Fixed by #74
Closed

Support mpv title-bar option #72

Keith94 opened this issue Oct 21, 2024 · 4 comments · Fixed by #74
Labels
feature request New feature or request

Comments

@Keith94
Copy link
Contributor

Keith94 commented Oct 21, 2024

Set title-bar=no in mpv.conf. OSC title bar doesn't show up when hovering title bar area.

See mpv-player/mpv#12894
@Keith94 Keith94 changed the title OSC title bar doesn't show when title-bar=no is used Support mpv title-bar option Oct 21, 2024
@Samillion
Copy link
Owner

Huh, I thought I already added that.

ModernZ/modernz.lua

Lines 2656 to 2659 in 54d04a0

mp.observe_property("title-bar", "bool", function(_, val)
state.title_bar = val
request_init_resize()
end)

@Keith94
Copy link
Contributor Author

Keith94 commented Oct 21, 2024

Also boxalpha not supported with title bar disabled,

mpv_OTBqRd8EXo

@Samillion Samillion linked a pull request Oct 21, 2024 that will close this issue
fix: respect title-bar config and show/hide top bar correctly #74
Merged
@Samillion
Copy link
Owner

Should be fixed.

  • Respects title-bar config
  • Show/hide top bar correct

@Keith94
Copy link
Contributor Author

Keith94 commented Oct 21, 2024

Works great !! Thanks for your efforts!

@Samillion Samillion added the feature request New feature or request label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: respect title-bar config and show/hide top bar correctly Samillion/ModernZ
2 participants
@Keith94 @Samillion