Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneExplorer] Ask config file name #637

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented May 13, 2022

This commit lets user choose a name of new configuration file
on 'create-cfg' command.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]

@dayo09 dayo09 changed the title [OneExplorer] Ask cfg filename for create-cfg [OneExplorer] Ask file name at creating cfg May 13, 2022
This commit lets user choose a name of new configuration file
on 'create-cfg' command.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 changed the title [OneExplorer] Ask file name at creating cfg file name at creating cfg May 13, 2022
@dayo09 dayo09 changed the title file name at creating cfg [OneExplorer] Ask config file name May 13, 2022
@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label May 13, 2022
@dayo09 dayo09 requested a review from llFreetimell May 13, 2022 08:28
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
llFreetimell
llFreetimell previously approved these changes May 13, 2022
Copy link
Contributor

@llFreetimell llFreetimell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

title: `Create ONE configuration of '${modelName}.${extName}' :`,
placeHolder: `${modelName}.cfg`,
value: `${modelName}.cfg`
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um,,, as I know showInputBox input from the user in the command palette position. I think it would be nice to proceed with a UX similar to the vscode file explorer when the user added a cfg file. In file explorer, when a new file is added, file will be added to the file explorer and the file name is directly input. What do you think about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same so tried to find one, but it was hard to find the proper API. Let me know if you know one :-D.
We can apply this one first and maybe we can tackle on it later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/vscode#97190

It is not possible to add edit box in tree view.

Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
Copy link
Contributor

@llFreetimell llFreetimell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

title: `Create ONE configuration of '${modelName}.${extName}' :`,
placeHolder: `${modelName}.cfg`,
value: `${modelName}.cfg`
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/vscode#97190

It is not possible to add edit box in tree view.

@dayo09
Copy link
Contributor Author

dayo09 commented May 17, 2022

@Samsung/one-vscode_committers PTAL :-D

@llFreetimell llFreetimell merged commit 262cbda into Samsung:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals 2 approvals required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants