-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneExplorer] Ask config file name #637
Conversation
This commit lets user choose a name of new configuration file on 'create-cfg' command. ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
title: `Create ONE configuration of '${modelName}.${extName}' :`, | ||
placeHolder: `${modelName}.cfg`, | ||
value: `${modelName}.cfg` | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um,,, as I know showInputBox
input from the user in the command palette position. I think it would be nice to proceed with a UX similar to the vscode file explorer when the user added a cfg file. In file explorer, when a new file is added, file will be added to the file explorer and the file name is directly input. What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same so tried to find one, but it was hard to find the proper API. Let me know if you know one :-D.
We can apply this one first and maybe we can tackle on it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not possible to add edit box in tree view.
Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
title: `Create ONE configuration of '${modelName}.${extName}' :`, | ||
placeHolder: `${modelName}.cfg`, | ||
value: `${modelName}.cfg` | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not possible to add edit box in tree view.
@Samsung/one-vscode_committers PTAL :-D |
This commit lets user choose a name of new configuration file
on 'create-cfg' command.
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]