-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp the single product screen #22
Comments
Hi, Can I work on this? |
I have some better designs in my mind for this page |
Yes, go ahead! |
@ManavSarkar, any updates? |
Can I take it? |
I am already working on it |
Yes sir, almost done and within tomorrow I will submit. |
@Saransh-cpp please can you guide where to publish the branch, in upstream or in origin |
Did you clone my repository or the forked repository? |
No I just cloned the repository.i was working on the issue 22 branch |
Have I made any mistake? |
@ManavSarkar First you have to Fork this Repo using the Fork button which is on the top-right side, then clone the forked repo onto your system, make the desired changes, then create a new branch for your changes, push that branch onto your repo and then open a Pull Request in the main Repository. |
@ManavSarkar, a workaround for your situation now -
Then you can push to origin |
Can I start from beginning by forking the repository and then paste the product page code. But it will have only single commit. Will that be fine? |
Yes, no issues! |
@Saransh-cpp Please confirm whether the UI is looking good or not. |
@all-contributors please add @arnav1776 for mentoring |
I've put up a pull request to add @arnav1776! 🎉 |
Yes, looks awesome! |
Description
The screen where a single product is displayed (a book) looks ugly, I'll see if I can update the data, but update the UI and make it consistent throughout the screen. You might need to deep dive into the code and make sure that nothing breaks, hence, putting this as a moderate issue.
Relevant file
Screenshot
The text was updated successfully, but these errors were encountered: