Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint all the files #4

Closed
Saransh-cpp opened this issue Nov 10, 2021 · 7 comments · Fixed by #60 or #130
Closed

Lint all the files #4

Saransh-cpp opened this issue Nov 10, 2021 · 7 comments · Fixed by #60 or #130
Labels
CodePeak easy Not a good first issue but easy multiple-contributors Multiple people can contribute SWoC

Comments

@Saransh-cpp
Copy link
Owner

Description

Right now the file names and the code is not linted properly (or does not follow the convention naming etc.). Lint all the files.

Multiple contributors

This issue can have multiple PRs but each PR should lint at least 3 files.
@Saransh-cpp Saransh-cpp added good first issue Good for newcomers multiple-contributors Multiple people can contribute labels Nov 10, 2021
@Starkl7
Copy link
Contributor

Starkl7 commented Dec 1, 2021

I would like to work on this as part of SWOC'21. Could you assign this issue to me?

@Saransh-cpp
Copy link
Owner Author

Sure, go ahead!

@Saransh-cpp
Copy link
Owner Author

@Starkl7, any updates on this?

@Starkl7
Copy link
Contributor

Starkl7 commented Dec 5, 2021

@Saransh-cpp I have finished linting all the files in lib, except those in Screens, will be submitting a PR by tonight for review.

@Starkl7 Starkl7 mentioned this issue Dec 7, 2021
Merged
@Starkl7
Copy link
Contributor

Starkl7 commented Dec 7, 2021

@Saransh-cpp I have created the pull request. Please review it.
Apologies for the delay, faced a few issues with version control.

@Starkl7
Copy link
Contributor

Starkl7 commented Dec 7, 2021

Should I proceed with the rest of the project?

@Saransh-cpp Saransh-cpp added easy Not a good first issue but easy moderate Moderate level issue and removed good first issue Good for newcomers multiple-contributors Multiple people can contribute easy Not a good first issue but easy labels Dec 8, 2021
@Saransh-cpp
Copy link
Owner Author

Re-opening this as #114 adds some more lint checks which would require the files to be formatted.

@Saransh-cpp Saransh-cpp reopened this Jan 3, 2022
@Saransh-cpp Saransh-cpp added good first issue Good for newcomers and removed moderate Moderate level issue labels Jan 3, 2022
@Saransh-cpp Saransh-cpp added multiple-contributors Multiple people can contribute easy Not a good first issue but easy and removed good first issue Good for newcomers labels Jan 6, 2022
@Saransh-cpp Saransh-cpp pinned this issue Jan 6, 2022
@Saransh-cpp Saransh-cpp mentioned this issue Jan 6, 2022
Merged
13 tasks
@Saransh-cpp Saransh-cpp unpinned this issue Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CodePeak easy Not a good first issue but easy multiple-contributors Multiple people can contribute SWoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linting all files in lib Starkl7/BookRentApp-Chapter3
Reformat Saransh-cpp/BookRentApp-Chapter3
2 participants
@Starkl7 @Saransh-cpp