You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ScanMountGoat
changed the title
make WriteOptions non exhaustive to limit breaking changes
limit breaking changes when adding new write options
Aug 14, 2024
Does simply adding #[non_exhaustive] to the write options solve this issue? It would be a breaking change right now, but would reduce the number of breaking changes in the future.
That would limit breaking changes. I've waited on implementing this since the examples are almost exclusively using the ..Default::default() syntax that won't work with #[non_exhaustive]. In practice, adding options won't break any code if people aren't initializing every field. I'm not against changing this to something else like the builder pattern in the future if there are a lot of additional configuration options.
No description provided.
The text was updated successfully, but these errors were encountered: