Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert default preconditioners #26

Closed
ChrisRackauckas opened this issue Nov 24, 2021 · 2 comments · Fixed by #33
Closed

Insert default preconditioners #26

ChrisRackauckas opened this issue Nov 24, 2021 · 2 comments · Fixed by #33

Comments

@ChrisRackauckas
Copy link
Member

The default preconditioners are then composed with any preconditioner placed in there, like is done in https://github.com/SciML/DiffEqBase.jl/blob/v6.76.0/src/linear_nonlinear.jl#L219-L226 . This is shown to almost always speed up the convergence.

@vpuri3
Copy link
Member

vpuri3 commented Nov 25, 2021

how do we want to go about this? cache is initialized with default scalevector preconditioner and then we compose that with alg.Pl,Pr? what should we initialize ScaleVector with - norm(b) or something?

@ChrisRackauckas
Copy link
Member Author

Yeah, see how it's done in the other repo. ComposePreconditioner make it easy to combine preconditioners, and then this one is added directly to whatever is put in, or if nothing this is the only one that is ran. That's a strategy taken from SUNDIALS because it generally gives a pretty good convergence boost, though it might be good to have a way to disable it just in case.

Ping @YingboMa if you need help on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants