Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to extrapolation based boundary proximity handling #136

Closed
xtalax opened this issue Jul 18, 2022 · 5 comments · Fixed by #138
Closed

Move to extrapolation based boundary proximity handling #136

xtalax opened this issue Jul 18, 2022 · 5 comments · Fixed by #138

Comments

@xtalax
Copy link
Member

xtalax commented Jul 18, 2022

Currently we use a stencil centrepoint shifting method to deal with domain edges, I propose moving to an extrapolation based approach to ensure stability, adding extra ghostpoints to pad the domain

@xtalax
Copy link
Member Author

xtalax commented Jul 18, 2022

@ChrisRackauckas @ranocha thoughts?

@ChrisRackauckas
Copy link
Member

Is the extrapolation stable? I don't remember it being so.

@xtalax
Copy link
Member Author

xtalax commented Jul 19, 2022

I would use lagrange weights, so likely not. There are some modified lagrange interpolations that claim better stability, may be better to use those.

Having thought about this I think I will use a high order interpolation that also references the boundary states, though am suspicious that this will work out equivalent to just shifting the centrepoint.

Perhaps a multidimensional interpolation would be better? I would need to generalise fornberg in this case which is a significant undertaking, but doable.

Whatever the case the current implementation has caused a lot of problems and needs to go, what would you suggest as an alternative to create additional ghost points?

@ranocha
Copy link
Member

ranocha commented Jul 19, 2022

The only provably stable WENO methods I know of are the ones of Carpenter et al.

You won't like that you need to know something about the equations you are discretizing - so it doesn't fit the general framework here. Having said that, I think Clawpack provides some extrapolation BCs for their WENO methods (but I can't give you specific references).

@hhaensel
Copy link

hhaensel commented Aug 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants