Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a timeout for pulls #23

Open
ScottG489 opened this issue Nov 19, 2020 · 0 comments
Open

Consider adding a timeout for pulls #23

ScottG489 opened this issue Nov 19, 2020 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@ScottG489
Copy link
Owner

We have a timeout for job run time but not for pulls. We don't want to pull an object for too long because that probably means it's going to be massive or there is some other issue with the pull. We can handle this by:

  • Including the pull time in the job run time which means there would be 1 total time between the two
  • Include a separate timeout just for the pull

I think I prefer the latter. It wouldn't make sense to allow a pull to go on for 30 minutes. It would also allow for jobs to know exactly how much time they have to run rather than having to worry about the ambiguity of how long a pull took.

It also might be a good idea to have an overall timeout. Perhaps rather than a job timeout of pull time + run time. We could have a pull time included in the overall timeout. If desired, this may be more complicated and should probably be made into a separate issue. Before closing this decide if this is something desired and if so make another issue.

@ScottG489 ScottG489 added enhancement New feature or request question Further information is requested labels Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant