Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DockerAdapter out of core.job into new core.adapter package #32

Open
ScottG489 opened this issue Apr 24, 2021 · 0 comments
Open

Move DockerAdapter out of core.job into new core.adapter package #32

ScottG489 opened this issue Apr 24, 2021 · 0 comments
Labels
good first issue Good for newcomers tech debt Code refactoring

Comments

@ScottG489
Copy link
Owner

DockerAdapter is the only core class that should have third party dependencies. Perhaps it shouldn't even live in core, but at least for now lets move it out of core.job.

After this is done, also create an ArchUnit test which makes sure that no packages in the entire project depend on the third party docker lib except that package.

@ScottG489 ScottG489 added good first issue Good for newcomers tech debt Code refactoring labels Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tech debt Code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant