Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostBodyTask for admin config endpoint #39

Open
ScottG489 opened this issue Jun 20, 2021 · 0 comments
Open

Use PostBodyTask for admin config endpoint #39

ScottG489 opened this issue Jun 20, 2021 · 0 comments
Labels
tech debt Code refactoring

Comments

@ScottG489
Copy link
Owner

ScottG489 commented Jun 20, 2021

PostBodyTask is more appropriate for the admin config endpoint used to do live updates to the applications config (currently only job limit config). The current config update endpoint only accepts GET requests. However, we are updating the config so a POST request is what's appropriate.

Look into this Task to fully evaluate if this is the better use case and then implement it.

Also refer to email "Regarding updating the dropwizard config on runtime" and see if we can give credit to the email's sender for letting me know about this Task.

@ScottG489 ScottG489 added the tech debt Code refactoring label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Code refactoring
Projects
None yet
Development

No branches or pull requests

1 participant