Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish function if lambda code changes #96

Open
abargnesi opened this issue Feb 15, 2018 · 3 comments
Open

Publish function if lambda code changes #96

abargnesi opened this issue Feb 15, 2018 · 3 comments
Assignees

Comments

@abargnesi
Copy link
Contributor

abargnesi commented Feb 15, 2018

Currently with version 2.3.2 I cannot publish a new version if only the lambda code package changes.

When we release our project we set publish to true and forceUpdate to false. We do not want to force update because that will deploy and publish new version even when the code/config have not changed.

What I propose is to additionally publish a new version if publish is true and the code package has been updated due to checksum differences.

Edit:

My motivation is production deployments only when there are actual λ code / config changes. Otherwise publishing different versions with the same effective config/code is redundant and confusing later.

@SeanRoy
Copy link
Owner

SeanRoy commented Feb 16, 2018

Sounds good. Were you planning to submit a PR?

@abargnesi
Copy link
Contributor Author

Sure I will take a crack at it.

@SeanRoy
Copy link
Owner

SeanRoy commented Feb 16, 2018

It's fine if you weren't, I just needed to know. If you still want to do it please be aware of the other PR that is touching some of the same code areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants