Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization] Reduce default brightness during QR code display [New contributor opportunity] #377

Closed
bitcoinprecept opened this issue May 28, 2023 · 1 comment
Closed

[Optimization] Reduce default brightness during QR code display [New contributor opportunity] #377

bitcoinprecept opened this issue May 28, 2023 · 1 comment

Comments

@bitcoinprecept
Copy link
Contributor

@SeedSigner has suggested to reduce the default brightness 2-3 levels for QR codes as they’re displayed for XPUBs and PSBTs. Logging this issue for development follow-up.

The code change to enable this is straightforward and could be a great opportunity for a new contributor to the project to dip their toes in.

If anyone has experience or opinions on the current UX around QR code brightness, essentially if you've had issues (or not) getting your QR codes read and it was remediated by brightness adjustment, feel free to comment below.
@newtonick
Copy link
Collaborator

newtonick commented May 28, 2023 •
edited
Loading

IMO #363 makes this less necessary to dial in perfectly, but is more dev work to implement.

@pythcoiner pythcoiner mentioned this issue May 30, 2023
Merged
@jdlcdl jdlcdl mentioned this issue Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newtonick @bitcoinprecept