Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings/Naming for _to_numpy method in SKLearn backend #812

Closed
2 tasks done
Tracked by #806
mauicv opened this issue Jun 12, 2023 · 0 comments · Fixed by #833
Closed
2 tasks done
Tracked by #806

Docstrings/Naming for _to_numpy method in SKLearn backend #812

mauicv opened this issue Jun 12, 2023 · 0 comments · Fixed by #833
Assignees
@mauicv

Comments

@mauicv
Copy link
Collaborator

mauicv commented Jun 12, 2023 •
edited
Loading

  • _to_numpy is really mapping from the backend dtype to the frontend type. This means the method is badly named so should be something like: map_to_backend_dtype.
  • I think we also need to make sure the docstrings are clear this is an interface method

See this comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauicv mauicv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename interface methods for mapping between frontend and backend mauicv/alibi-detect
1 participant
@mauicv