Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Java project #937

Closed
adriangonz opened this issue Oct 10, 2019 · 0 comments · Fixed by #951
Closed

Tidy up Java project #937

adriangonz opened this issue Oct 10, 2019 · 0 comments · Fixed by #951
Assignees

Comments

@adriangonz
Copy link
Contributor

Context

The Java code on the engine currently has a mix of spaces and tabs, unused dependencies, deprecation notices, different coding styles, etc. It would be good to add linters which check for these (i.e. static checks) and auto-formatters which force the code to comply with a certain style guideline.

Suggestions

We can look into large Java projects (e.g. spring-framework) to see which tools they use. Ideally both the linters and autoformatters should be integrated with mvn and the former should get triggered by git hooks, to ensure that the conventions are always followed.

Ideally, the build should stop if any of the checks fails.

@adriangonz adriangonz self-assigned this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant