From 3d900a31b446373662fccd693c5c6cb8f7842d5e Mon Sep 17 00:00:00 2001
From: Clive Cox <cc@seldon.io>
Date: Mon, 14 Sep 2020 08:50:44 +0100
Subject: [PATCH 1/2] Update single helm chart

---
 .../seldon-single-model/templates/seldondeployment.json    | 7 ++++++-
 helm-charts/seldon-single-model/values.yaml                | 5 +++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/helm-charts/seldon-single-model/templates/seldondeployment.json b/helm-charts/seldon-single-model/templates/seldondeployment.json
index 02e657bc77..8dbfbd5ca2 100644
--- a/helm-charts/seldon-single-model/templates/seldondeployment.json
+++ b/helm-charts/seldon-single-model/templates/seldondeployment.json
@@ -11,7 +11,9 @@
     }
   },
   "spec": {
-    "name": "{{ .Release.Name }}",
+      "name": "{{ .Release.Name }}",
+      "protocol": "{{ .Values.protocol }}",
+      "transport": "{{ .Values.transport }}",      
     "annotations": {
       {{- range $name, $val := .Values.annotations }}
         "{{ $name }}": "{{ $val }}",
@@ -25,6 +27,9 @@
           {{- if .Values.model.implementation }}
           "implementation": "{{ .Values.model.implementation }}",
           {{- end}}
+          {{- if .Values.model.envSecretRefName }}
+          "envSecretRefName": "{{ .Values.model.envSecretRefName }}",
+          {{- end}}
           {{- if .Values.model.uri }}
           "modelUri": "{{ .Values.model.uri }}",
           {{- end}}
diff --git a/helm-charts/seldon-single-model/values.yaml b/helm-charts/seldon-single-model/values.yaml
index 4f7c39b689..12cdcd808c 100644
--- a/helm-charts/seldon-single-model/values.yaml
+++ b/helm-charts/seldon-single-model/values.yaml
@@ -1,11 +1,16 @@
 # apiVersion -- Version of the SeldonDeployment CRD
 apiVersion: machinelearning.seldon.io/v1
 
+protocol: seldon
+transport: rest
+
 model:
   # model.implementation -- Implementation of Prepackaged Model Server
   implementation: ""
   # model.uri -- Model's URI for prepackaged model server
   uri: ""
+  # model.envSecretRefName -- The model secret name for enviroment variables
+  envSecretRefName: ""
   # model.image -- Docker image used by the model
   image: ""
   # model.env -- Environment variables injected into the model's container

From 9077b9ce8b107e9a26035533652f116f6dc69419 Mon Sep 17 00:00:00 2001
From: Clive Cox <cc@seldon.io>
Date: Mon, 14 Sep 2020 17:01:32 +0100
Subject: [PATCH 2/2] Add mlflow features

---
 .../seldon-single-model/templates/seldondeployment.json  | 9 +++++++++
 helm-charts/seldon-single-model/values.yaml              | 2 ++
 2 files changed, 11 insertions(+)

diff --git a/helm-charts/seldon-single-model/templates/seldondeployment.json b/helm-charts/seldon-single-model/templates/seldondeployment.json
index 8dbfbd5ca2..8bcd4d1666 100644
--- a/helm-charts/seldon-single-model/templates/seldondeployment.json
+++ b/helm-charts/seldon-single-model/templates/seldondeployment.json
@@ -33,6 +33,15 @@
           {{- if .Values.model.uri }}
           "modelUri": "{{ .Values.model.uri }}",
           {{- end}}
+          {{- if .Values.model.mlflow.xtype }}
+          "parameters": [
+		{
+		    "name": "xtype",
+		    "type": "STRING",
+		    "value": "{{ .Values.model.mlflow.xtype }}" 
+		}
+	  ],
+          {{- end}}
           "type": "MODEL",
           {{- if .Values.model.logger.enabled }}
           "logger": {
diff --git a/helm-charts/seldon-single-model/values.yaml b/helm-charts/seldon-single-model/values.yaml
index 12cdcd808c..57b8b7903c 100644
--- a/helm-charts/seldon-single-model/values.yaml
+++ b/helm-charts/seldon-single-model/values.yaml
@@ -25,6 +25,8 @@ model:
     enabled: false
     # logger.url -- Remote URL for logger
     url: ""
+  mlflow:
+    xtype: ""
 
 # replicas -- Number of replicas for the predictor
 replicas: 1