From 4513ea982c0ec33f54552a6849c165a62f661b08 Mon Sep 17 00:00:00 2001 From: titusfortner Date: Fri, 12 Jan 2024 09:43:46 -0600 Subject: [PATCH] [py] remove deprecated verbose argument from edge service --- py/selenium/webdriver/edge/service.py | 10 -------- .../webdriver/edge/edge_service_tests.py | 23 ------------------- 2 files changed, 33 deletions(-) delete mode 100644 py/test/unit/selenium/webdriver/edge/edge_service_tests.py diff --git a/py/selenium/webdriver/edge/service.py b/py/selenium/webdriver/edge/service.py index 881fc622784a3..7a9142ce75467 100644 --- a/py/selenium/webdriver/edge/service.py +++ b/py/selenium/webdriver/edge/service.py @@ -15,7 +15,6 @@ # specific language governing permissions and limitations # under the License. import typing -import warnings from selenium.types import SubprocessStdAlias from selenium.webdriver.chromium import service @@ -38,7 +37,6 @@ def __init__( self, executable_path: str = None, port: int = 0, - verbose: bool = False, log_output: SubprocessStdAlias = None, service_args: typing.Optional[typing.List[str]] = None, env: typing.Optional[typing.Mapping[str, str]] = None, @@ -46,14 +44,6 @@ def __init__( ) -> None: self.service_args = service_args or [] - if verbose: - warnings.warn( - "verbose=True is deprecated. Use `service_args=['--verbose', ...]` instead.", - DeprecationWarning, - stacklevel=2, - ) - self.service_args.append("--verbose") - super().__init__( executable_path=executable_path, port=port, diff --git a/py/test/unit/selenium/webdriver/edge/edge_service_tests.py b/py/test/unit/selenium/webdriver/edge/edge_service_tests.py deleted file mode 100644 index 0fa8408769e9e..0000000000000 --- a/py/test/unit/selenium/webdriver/edge/edge_service_tests.py +++ /dev/null @@ -1,23 +0,0 @@ -# Licensed to the Software Freedom Conservancy (SFC) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The SFC licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -import pytest - - -def test_edge_service_verbose_flag_is_deprecated(edge_service) -> None: - with pytest.warns(match="verbose=True is deprecated", expected_warning=DeprecationWarning): - edge_service(verbose=True)