From 4dc45f7d8412424c23a3b9ea0ff4a7258be0da6d Mon Sep 17 00:00:00 2001 From: titusfortner Date: Fri, 19 Jan 2024 09:53:24 -0600 Subject: [PATCH] [dotnet] remove download url parameter from driver service constructor nothing is done with this parameter and users passing in a value should get an error rather than having it be ignored --- dotnet/src/webdriver/Chromium/ChromiumDriverService.cs | 3 +-- dotnet/src/webdriver/DriverService.cs | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dotnet/src/webdriver/Chromium/ChromiumDriverService.cs b/dotnet/src/webdriver/Chromium/ChromiumDriverService.cs index 6280bbee774cc..3c7aafe0378b3 100644 --- a/dotnet/src/webdriver/Chromium/ChromiumDriverService.cs +++ b/dotnet/src/webdriver/Chromium/ChromiumDriverService.cs @@ -45,8 +45,7 @@ public abstract class ChromiumDriverService : DriverService /// The full path to the ChromeDriver executable. /// The file name of the ChromeDriver executable. /// The port on which the ChromeDriver executable should listen. - /// The URL from which the driver executable can be downloaded. - protected ChromiumDriverService(string executablePath, string executableFileName, int port, Uri downloadUrl = null) + protected ChromiumDriverService(string executablePath, string executableFileName, int port) : base(executablePath, port, executableFileName) { } diff --git a/dotnet/src/webdriver/DriverService.cs b/dotnet/src/webdriver/DriverService.cs index 77f2eb10e6f3f..691fc18f21a0f 100644 --- a/dotnet/src/webdriver/DriverService.cs +++ b/dotnet/src/webdriver/DriverService.cs @@ -50,14 +50,13 @@ public abstract class DriverService : ICommandServer /// The full path to the directory containing the executable providing the service to drive the browser. /// The port on which the driver executable should listen. /// The file name of the driver service executable. - /// This parameter is no longer used; kept for backwards compatibility. /// /// If the path specified is or an empty string. /// /// /// If the specified driver service executable does not exist in the specified directory. /// - protected DriverService(string servicePath, int port, string driverServiceExecutableName, Uri driverServiceDownloadUrl = null) + protected DriverService(string servicePath, int port, string driverServiceExecutableName) { this.driverServicePath = servicePath; this.driverServiceExecutableName = driverServiceExecutableName;