-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚀 Feature]: Require Java 17 #14022
Comments
Why not going to 21 (also LTS) instead? |
It is just easier to convince people to do the shorter jump. I also had in mind the requirement to have at least Java 17 in autumn, at the beginning of winter. Even if Selenium 5 does not happen. |
The only jump you have to convince people to, is to drop JDK 8. I would also vote for targeting the most recent LTS release. |
https://www.selenium.dev/blog/2023/java-8-support/ Since 4.14, Java 11 is required. |
That's what I mean 😅 the biggest step was done. |
Java 17 is EOL in September 2024 |
@diemol / @pujagani / @joerg1985 If we don't have anything specific, it might make more sense to update more slowly. For Java 11 we had a specific need for the http client. |
+1 to Titus and Diego's thought process. I don't know anything pressing that requires Java 21 right off the bat in our codebase. I am in favour of updating slowly since it is not a trivial task in many organizations/users due to various reasons based on what I have seen. |
I don't think there is a specific improvment in 21 that could be helpful currently. |
I'm seeing this as the "End of Public Updates" for Java 17:
If we don't have anything specific in mind to target Java 21, I think we should continue to support Java 17 |
In other languages we remove support for versions that are no longer "officially" supported.
|
The New Relic report is pretty insightful: https://newrelic.com/resources/report/2024-state-of-the-java-ecosystem Two key points:
|
Ouch, if we require Java 17, that's over 60% of people right now where it wouldn't match their current dev environments, so we may want to be more conservative; especially if there isn't anything we need to upgrade for (like we did for Java 11). If we use the Eclipse EOL dates that's:
Is that too conservative? |
Jenkins went through 3 proposals and landed on supporting 2 LTS versions at any given time: Therefore, the Jenkins project is adopting a 2 + 2 + 2 Java support plan, where Jenkins supports a new Java LTS release in the first two years after the general availability of that Java LTS release, then requires that Java LTS release as the Jenkins minimum Java version in the next two years of that Java LTS release’s upstream support, then drops support for that Java LTS release two years before that Java LTS release reaches end of life upstream. In practice, this means that Jenkins will support a given Java LTS release for approximately two-thirds the amount of time that upstream Java vendors do, that Jenkins will support two Java LTS releases at any given time rather than three, and that large scale users can stay on a Java LTS release for four years at a time. https://www.jenkins.io/blog/2023/11/06/introducing-2-2-2-java-support-plan/ I suspect differing needs of features however, with Selenium. |
I think the base line is the support of the netty and the graphql dependencies. They are hard to replace and externally exposed by the server, so there must be support from a security point of view. Everything else could be somehow replaced. But i don't know the jdk support plan of them. |
Wow, so Jenkins is being very aggressive. Comparison of options:
|
This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stalled for 14 days with no activity. |
Was there a conclusion to this with Java 17/21 LTS support? I would argue for 21 LTS though it seems most are going with a hard requirement of 17 at least. Maven 4 will require Java 17 for example. https://lists.apache.org/thread/145fmwcfrt0qo1qwfpop7rozhsrv60wk Interesting comment here in relation to the JDK support for Maven 4: Managed to find an interesting report from the Eclipse Foundation, mostly focused on Jakarta but seems adoption is quite fast pace: https://outreach.eclipse.foundation/hubfs/2024%20Jakarta%20EE%20Developer%20Survey%20Report%20.pdf |
Feature and motivation
We talked last year about requiring Java 17 later this year, are we still on track for that?
Would it make sense to make that part of Selenium 5?
Usage example
n/a
The text was updated successfully, but these errors were encountered: