From cedf2f39198480c4a06d7c0bb9bd31875d308521 Mon Sep 17 00:00:00 2001 From: bastimeyer Date: Mon, 5 Jun 2023 20:14:24 +0200 Subject: [PATCH 1/2] [py] Fix KeyError on BrowserError --- py/selenium/webdriver/common/bidi/cdp.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/selenium/webdriver/common/bidi/cdp.py b/py/selenium/webdriver/common/bidi/cdp.py index 7ad5b0c622e24..d9c6a851ea242 100644 --- a/py/selenium/webdriver/common/bidi/cdp.py +++ b/py/selenium/webdriver/common/bidi/cdp.py @@ -147,8 +147,8 @@ class BrowserError(Exception): indicates that an error occurred.""" def __init__(self, obj): - self.code = obj["code"] - self.message = obj["message"] + self.code = obj.get("code") + self.message = obj.get("message") self.detail = obj.get("data") def __str__(self): From 3ea8583c134b0874e01f91c2ba781fc45eb28bd5 Mon Sep 17 00:00:00 2001 From: bastimeyer Date: Mon, 5 Jun 2023 20:14:41 +0200 Subject: [PATCH 2/2] [py] Fix TypeError on BrowserError --- py/selenium/webdriver/common/bidi/cdp.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/py/selenium/webdriver/common/bidi/cdp.py b/py/selenium/webdriver/common/bidi/cdp.py index d9c6a851ea242..f7e18c0896cc9 100644 --- a/py/selenium/webdriver/common/bidi/cdp.py +++ b/py/selenium/webdriver/common/bidi/cdp.py @@ -442,7 +442,13 @@ async def _reader_task(self): try: session = self.sessions[session_id] except KeyError: - raise BrowserError(f"Browser sent a message for an invalid session: {session_id!r}") + raise BrowserError( + { + "code": -32700, + "message": "Browser sent a message for an invalid session", + "data": f"{session_id!r}", + } + ) session._handle_data(data) else: self._handle_data(data)