diff --git a/.eslintrc b/.eslintrc index 9a37b08057..12880dff98 100644 --- a/.eslintrc +++ b/.eslintrc @@ -25,6 +25,7 @@ "semi": [2, "never"], "jsx-a11y/alt-text": 1, "jsx-a11y/label-has-for": 1, + "jsx-a11y/no-static-element-interactions": 1, "jsx-a11y/role-has-required-aria-props": 1, "import/no-dynamic-require": 0, "import/no-extraneous-dependencies": 0, diff --git a/docs/src/components/ComponentDoc/ComponentDocLinks.js b/docs/src/components/ComponentDoc/ComponentDocLinks.js index 8188870a11..589ea6743c 100644 --- a/docs/src/components/ComponentDoc/ComponentDocLinks.js +++ b/docs/src/components/ComponentDoc/ComponentDocLinks.js @@ -33,7 +33,7 @@ export default class ComponentDocLinks extends PureComponent { - + {repoPath} @@ -43,7 +43,7 @@ export default class ComponentDocLinks extends PureComponent { {suiLink && ( + Semantic UI {displayName} Docs } diff --git a/docs/src/components/IconSearch/IconSearch.js b/docs/src/components/IconSearch/IconSearch.js index 9ab0b8e794..d97cd05dd5 100644 --- a/docs/src/components/IconSearch/IconSearch.js +++ b/docs/src/components/IconSearch/IconSearch.js @@ -115,7 +115,6 @@ export default class IconSearch extends Component { mouseEnterDelay={1000} inverted closeOnTriggerClick={false} - closeOnRootNodeClick={false} closeOnDocumentClick={false} style={{ width: '8em', textAlign: 'center' }} size='mini' diff --git a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleForm.js b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleForm.js index caba3ea53c..a35d34e237 100644 --- a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleForm.js +++ b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleForm.js @@ -3,10 +3,10 @@ import { Accordion, Button, Form, Segment } from 'semantic-ui-react' const panels = [ { + key: 'details', title: 'Optional Details', content: { as: Form.Input, - key: 'content', label: 'Maiden Name', placeholder: 'Maiden Name', }, diff --git a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleNested.js b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleNested.js index b94edb868a..34d96046a3 100644 --- a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleNested.js +++ b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleNested.js @@ -2,8 +2,8 @@ import React from 'react' import { Accordion } from 'semantic-ui-react' const level1Panels = [ - { title: 'Level 1A', content: 'Level 1A Contents' }, - { title: 'Level 1B', content: 'Level 1B Contents' }, + { key: 'panel-1a', title: 'Level 1A', content: 'Level 1A Contents' }, + { key: 'panel-ba', title: 'Level 1B', content: 'Level 1B Contents' }, ] const Level1Content = ( @@ -14,8 +14,8 @@ const Level1Content = ( ) const level2Panels = [ - { title: 'Level 2A', content: 'Level 2A Contents' }, - { title: 'Level 2B', content: 'Level 2B Contents' }, + { key: 'panel-2a', title: 'Level 2A', content: 'Level 2A Contents' }, + { key: 'panel-2b', title: 'Level 2B', content: 'Level 2B Contents' }, ] const Level2Content = ( @@ -26,8 +26,8 @@ const Level2Content = ( ) const rootPanels = [ - { title: 'Level 1', content: { content: Level1Content, key: 'content-1' } }, - { title: 'Level 2', content: { content: Level2Content, key: 'content-2' } }, + { key: 'panel-1', title: 'Level 1', content: { content: Level1Content } }, + { key: 'panel-2', title: 'Level 2', content: { content: Level2Content } }, ] const AccordionExampleNested = () => diff --git a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleShorthand.js b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleShorthand.js index 2807c99193..6b788ca2fc 100644 --- a/docs/src/examples/modules/Accordion/Advanced/AccordionExampleShorthand.js +++ b/docs/src/examples/modules/Accordion/Advanced/AccordionExampleShorthand.js @@ -4,13 +4,12 @@ import React from 'react' import { Accordion, Label, Message } from 'semantic-ui-react' const panels = _.times(3, i => ({ + key: `panel-${i}`, title: { content: