-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute the icons to FontAwesome #1901
Comments
There are no fonts or styles in this repository. All styles are from Semantic UI proper. |
Yes, but doesn't this repo control this page?: https://react.semantic-ui.com/elements/icon What I'm saying is that page should mention fontawesome, so it's clear where the icons are coming from. |
A simple Message up top that notifies the user where icons are from should do. |
Hey @levithomason, should this be added here, or somewhere else? I'd like to make a PR. |
@yeskunall I'm sure that it should be added there: <Message>
Semantic includes ....
</Message> |
It took me a while, and a little source code digging to find where the icon set was coming from (FontAwesome). It's mentioned on the other doc site, but not on the react one. I think it should be added there, and the readme of this repo and the main repo.
The text was updated successfully, but these errors were encountered: