Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: dimmer={false} stops the modal from opening #2873

Closed
mihai-dinculescu opened this issue Jun 4, 2018 · 4 comments · Fixed by #2882
Closed

Modal: dimmer={false} stops the modal from opening #2873

mihai-dinculescu opened this issue Jun 4, 2018 · 4 comments · Fixed by #2882
Labels

Comments

@mihai-dinculescu
Copy link
Member

mihai-dinculescu commented Jun 4, 2018

Bug Report

Steps

A Modal with dimmer={false}.

Expected Result

The modal opens.

Actual Result

The modal doesn't open. This can be observed in the docs.

Version

0.81.1

Testcase

https://react.semantic-ui.com/modules/modal#variations-dimmer
https://react.semantic-ui.com/modules/modal#types-multiple

@mihai-dinculescu mihai-dinculescu changed the title Modal: dimmer={false} stopes the modal from opening Modal: dimmer={false} stops the modal from opening Jun 4, 2018
@triage-new-issues triage-new-issues bot removed the triage label Jun 5, 2018
@Xecutor
Copy link

Xecutor commented Jun 5, 2018

It's actually opening. But it's at the bottom of the page, under all other content.

@layershifter
Copy link
Member

As I see, a Modal component is not longer usable without a dimmer. Can anybode confirm this?

@mihai-dinculescu
Copy link
Member Author

mihai-dinculescu commented Jun 5, 2018

This is caused by Semantic CSS 2.3. Without a dimmer, it is no longer able to figure out the position of the modal.

Looking at https://github.com/Semantic-Org/Semantic-UI/releases, I've noticed:

A Special Message about Flex Modals

There will be an update shortly to resolve issues related to flex modals when using multiple modals and detachable: false, in order to not hold up this release, we've decided to move forward without a fix.

A general solution will most likely require branching code for IE11 which will disable flex (as IE11 doesnt correctly implement the latest spec for absolute positioned flex containers).

@layershifter
Copy link
Member

It seems, that need update the Modals code, it doesn't accept booleans now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants