Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: scrolling issue with top aligned #2891

Closed
ak1394 opened this issue Jun 7, 2018 · 7 comments · Fixed by #3679
Closed

Modal: scrolling issue with top aligned #2891

ak1394 opened this issue Jun 7, 2018 · 7 comments · Fixed by #3679

Comments

@ak1394
Copy link

ak1394 commented Jun 7, 2018

Bug Report

Steps

  1. Go to Top Aligned Modal demo and open modal by clicking on "Show Modal" button.

  2. Start resizing browser window to a smaller size so that the window height is slightly less then a height of a modal.

  3. Observe that its possible to resize window that is hides a lower part of a modal, and no scroll bars are displayed. This doesn't happen to modals without centered={false} setting.

Expected Result

Vertical scrollbar should be displayed, when bottom of the modal is obscured.

Actual Result

Scroll bar is not displayed, and its impossible to reveal obscured bottom part of the modal by scrolling.

Version

0.81.1

@welcome
Copy link

welcome bot commented Jun 7, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

layershifter commented Jul 10, 2018

image

I am not able to reproduce. Please check again, if issue is reproduced, please add browser version. I will reopen, if will receive a valid follow up.

@ak1394
Copy link
Author

ak1394 commented Jul 10, 2018

Its Chrome v67.0.3396.99. I think in your case the window is a bit too small, if you slowly resize window by dragging it with the mouse, gradually increasing it's height, you should be able to observe the buggy behaviour.

For example: small window, scroll bar appears:

image

Slightly taller window (but not tall enough to fit the contents), no scroll bar:

image

@layershifter
Copy link
Member

Thanks 👍 As I see that the issue has a same place as #2221, however I will reopen this issue.

@layershifter layershifter reopened this Jul 10, 2018
@layershifter layershifter changed the title Scrolling issue with Top aligned Modals Modal: scrolling issue with top aligned Jul 10, 2018
@ak1394
Copy link
Author

ak1394 commented Jul 10, 2018

Thanks!

@stale
Copy link

stale bot commented Jan 6, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jan 6, 2019
@stale
Copy link

stale bot commented Jul 5, 2019

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants