Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: is not rendered when trigger is React.Fragment #3928

Closed
sergii-van opened this issue Apr 6, 2020 · 2 comments · Fixed by #3998
Closed

Popup: is not rendered when trigger is React.Fragment #3928

sergii-van opened this issue Apr 6, 2020 · 2 comments · Fixed by #3998
Labels

Comments

@sergii-van
Copy link

Bug Report

Steps

Popup does not appear when the trigger component is React.Fragment (<>)

Expected Result

Popup should be displayed

Actual Result

Popup does not render

Version

0.88.2

Testcase

https://codesandbox.io/s/little-sunset-j0lsf

@welcome
Copy link

welcome bot commented Apr 6, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title Popup is not rendered when trigger is React.Fragment Popup: is not rendered when trigger is React.Fragment Jul 27, 2020
@layershifter
Copy link
Member

@sergii-van thanks for reporting, I merged #3998 recently to add meaningful errors. It's impossible to use React.Fragment as we React.cloneElement() to add props to a passed element to the trigger prop.

I also reopened #1187 to consider a better approach than React.createElement().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants