You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Steps to Reproduce
Copy and paste a modal and include onClose in the <Modal> tag
Expected
No error
Result
Unknown prop onClose on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop. In div (created by Modal)
I suspect this is due to an older version. We recently updated the Modal from onHide to onClose. Though, the latest master does not throw this warning, neither do the latest docs for the Modal with onClose: http://localhost:8080/modules/modal#close-config
Our components "consume" props that they handle, and pass the rest on the underlying element. If you're on a version where the Modal does not handle and consume the onClose prop, then it will pass it to the div and cause this error.
Closing as I cannot reproduce on the latest. Feel offer more info if you see the error after updating.
Steps to Reproduce
Copy and paste a modal and include onClose in the
<Modal>
tagExpected
No error
Result
Unknown prop
onClose
on<div>
tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop. In div (created by Modal)I looked more into this and it lead me to:
react-bootstrap/react-bootstrap#1994
which lead me to:
facebook/react#6800
Sorry if you guys are already aware of this. Poked around a bit and didn't see anyone bring this up yet.
The text was updated successfully, but these errors were encountered: