Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown keyboard arrows don't work when rendering with children dropdown menu #993

Closed
fracmak opened this issue Dec 6, 2016 · 1 comment

Comments

@fracmak
Copy link
Member

fracmak commented Dec 6, 2016

You can see this on the docs page, example: http://react.semantic-ui.com/modules/dropdown#dropdown

Gives the error Uncaught TypeError: Cannot read property 'length' of undefined because getMenuOptions() doesn't know anything about the child menu items and returns undefined

Version

0.61.10

@levithomason
Copy link
Member

This is a known issue, however, I'm not sure that we'll support any subcomponents in the Dropdown in the long term. There is simply too much wiring involved to manage state and event handlers to make it worthwhile for users. Said wiring can be offloaded to the Dropdown if the children are defined via props instead (i.e. options, etc) where the Dropdown itself can then manage state and handle events.

You can see more on the discussion around extending the API in #889. I'll close this issue in favor of continued conversation over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants