Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UI refresh after content actions #1003

Merged
merged 7 commits into from
Oct 19, 2020
Merged

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Oct 7, 2020

extra fixes not directly related to the connected issue:

  • boolean input field was checked when default value is false
  • bug fixed in getUrlForContent (in rare cases navigated to another menu with invalid path)
  • edit view not displayed error after save
  • view title icon

@taki9 taki9 requested review from herflis and enikonemeth October 7, 2020 15:34
@taki9 taki9 self-assigned this Oct 7, 2020
@sensenet
Copy link

sensenet bot commented Oct 7, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://5f89dda6084e2f109aa81ace--sn-react-component-docs-dev.netlify.app Fri Oct 16 2020 - 17:51:57 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5f89dda883cc570dfd1c866a--sn-app-dev.netlify.app Fri Oct 16 2020 - 17:51:37 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1003 into develop will increase coverage by 0.03%.
The diff coverage is 71.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1003      +/-   ##
===========================================
+ Coverage    92.18%   92.22%   +0.03%     
===========================================
  Files          217      217              
  Lines         5928     5942      +14     
  Branches      1523     1540      +17     
===========================================
+ Hits          5465     5480      +15     
+ Misses         463      462       -1     
Impacted Files Coverage Δ
...s/sn-hooks-react/src/context/current-ancestors.tsx 78.26% <0.00%> (+3.26%) ⬆️
...es/sn-hooks-react/src/context/current-children.tsx 86.66% <70.58%> (+3.64%) ⬆️
...ckages/sn-client-core/src/Repository/Repository.ts 98.70% <100.00%> (ø)
...ges/sn-hooks-react/src/context/current-content.tsx 86.95% <100.00%> (-0.28%) ⬇️
packages/sn-repository-events/src/EventHub.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4378940...d3edc01. Read the comment docs.

@taki9 taki9 marked this pull request as ready for review October 13, 2020 16:05
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯‍♀️

@taki9 taki9 merged commit 46c9052 into develop Oct 19, 2020
@enikonemeth enikonemeth deleted the feature/refresh-after-actions branch November 23, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants