Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No error notification from group membership dialog #1073

Closed
herflis opened this issue Nov 5, 2020 · 0 comments · Fixed by #1080
Closed

[BUG] No error notification from group membership dialog #1073

herflis opened this issue Nov 5, 2020 · 0 comments · Fixed by #1080
Assignees
Labels
admin-ui bug Something isn't working
Milestone

Comments

@herflis
Copy link
Contributor

herflis commented Nov 5, 2020

🐜 Bug Report

I've tested the new builtin user and group protection feature and it turned out that there is no error notification when an error occurs in the group membership dialog.

📦 Package / Application

@sensenet/sn-app

📃 Version

latest (develop)

🐜 Describe the bug

There are cases when a user could not be removed from a group and the backend throws an error but it is not handled on the client.

👉 Steps To Reproduce

  1. Login to the netcore test repository on the admin-ui with businesscat
  2. Go to Users & Groups and switch to groups
  3. Click on the member button at the administrators group's row
  4. Try to remove businesscat

😯 Current behavior

No notification with the error message is shown after the request.

🤔 Expected behavior

A notification should appear with the message of the actual error.

@herflis herflis added the bug Something isn't working label Nov 5, 2020
@herflis herflis added this to the Sprint 222 milestone Nov 5, 2020
@taki9 taki9 self-assigned this Nov 10, 2020
@herflis herflis linked a pull request Nov 11, 2020 that will close this issue
@herflis herflis modified the milestones: Sprint 222, Sprint 223 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-ui bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants