From 4b6fe1a6e85d8c5ae552f2c4d2e219fd8c10438e Mon Sep 17 00:00:00 2001 From: Maxime Gasse Date: Thu, 14 Nov 2024 15:25:45 -0500 Subject: [PATCH 1/4] updated libwebarena / libvisualwebarena dependencies --- browsergym/visualwebarena/requirements.txt | 2 +- browsergym/webarena/requirements.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/browsergym/visualwebarena/requirements.txt b/browsergym/visualwebarena/requirements.txt index 8227effc..e582e258 100644 --- a/browsergym/visualwebarena/requirements.txt +++ b/browsergym/visualwebarena/requirements.txt @@ -1,5 +1,5 @@ browsergym-core==0.13.0 browsergym-webarena -libvisualwebarena==0.0.14 +libvisualwebarena==0.0.15 requests torch diff --git a/browsergym/webarena/requirements.txt b/browsergym/webarena/requirements.txt index d638bf67..e4466588 100644 --- a/browsergym/webarena/requirements.txt +++ b/browsergym/webarena/requirements.txt @@ -1,2 +1,2 @@ browsergym-core==0.13.0 -libwebarena==0.0.3 +libwebarena==0.0.4 From cf789e471b9b09516c668510cd15e8ef89d80f9d Mon Sep 17 00:00:00 2001 From: Maxime Gasse Date: Fri, 15 Nov 2024 09:53:11 -0500 Subject: [PATCH 2/4] test fix --- tests/core/test_registration.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/core/test_registration.py b/tests/core/test_registration.py index ddd7f9e4..edf57c77 100644 --- a/tests/core/test_registration.py +++ b/tests/core/test_registration.py @@ -7,7 +7,7 @@ from browsergym.core.task import AbstractBrowserTask -class TestTask(AbstractBrowserTask): +class RegistrationTestTask(AbstractBrowserTask): @classmethod def get_task_id(cls): raise NotImplementedError @@ -28,10 +28,10 @@ def validate(self, page, chat_messages): return 0, True, "", {} -register_task("test_task", TestTask) +register_task("test_task", RegistrationTestTask) register_task( "test_task_with_defaults", - TestTask, + RegistrationTestTask, task_kwargs={"a": "new value"}, default_task_kwargs={"b": 1}, ) @@ -42,7 +42,7 @@ def test_registration(): with pytest.raises(ValueError): register_task( "test_task_forbidden", - TestTask, + RegistrationTestTask, task_kwargs={"a": "new value"}, default_task_kwargs={"a": "other value"}, ) From fe9788f50d966aba8c4fcfa58dea9a77c30efe5b Mon Sep 17 00:00:00 2001 From: Maxime Gasse Date: Fri, 15 Nov 2024 10:58:13 -0500 Subject: [PATCH 3/4] test fix --- tests/core/test_observation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core/test_observation.py b/tests/core/test_observation.py index 6c7f5e36..36bb3419 100644 --- a/tests/core/test_observation.py +++ b/tests/core/test_observation.py @@ -263,7 +263,7 @@ def test_dom_has_bids_no_aria(url): # exceptions dom_node_names_without_bid = ["html", "#text", "#document", "#comment"] - axtree_roles_without_bid = ["RootWebArea", "none", "generic", "StaticText"] + axtree_roles_without_bid = ["RootWebArea", "none", "generic", "StaticText", "InlineTextBox"] # 1. test the DOM snapshot for BID_ATTR, "aria-description" and "aria-roledescription" From 748755fd384372c71e3d9f2bcf5d4de84f7d4c6c Mon Sep 17 00:00:00 2001 From: Maxime Gasse Date: Fri, 15 Nov 2024 11:10:26 -0500 Subject: [PATCH 4/4] test fix --- tests/core/test_actions_highlevel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core/test_actions_highlevel.py b/tests/core/test_actions_highlevel.py index 9540c9c2..a3a4f56c 100644 --- a/tests/core/test_actions_highlevel.py +++ b/tests/core/test_actions_highlevel.py @@ -405,7 +405,7 @@ def test_invalid_action(): obs, reward, term, trunc, info = env.step(action) # error - assert obs["last_action_error"] == "Error: modifiers: expected array, got string" + assert obs["last_action_error"] == "Error: Locator.click: modifiers: expected array, got string" # invalid action args (not enough) action = f"""\