Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated "Etc/GMT±n" timezones in Zend_Date #305

Closed
elidrissidev opened this issue Jan 10, 2023 · 7 comments
Closed

Avoid using deprecated "Etc/GMT±n" timezones in Zend_Date #305

elidrissidev opened this issue Jan 10, 2023 · 7 comments

Comments

@elidrissidev
Copy link

The bug that was happening lately in PHP 8.1.14 and 8.2.1 revealed that Zend_Date class was using some old and deprecated timezones when trying to guess a timezone from a string date (e.g. 2022-12-27T08:15:24-08:00), this was happening in the constructor so there was no way around it even if you plan to setTimezone() later after constructing the Zend_Date object.

Although it has been reported that the bug was resolved in the upcoming PHP version, it still would be good to address this issue to avoid any potential problems in the future. But I'm still not sure how to address this.

Related links:

@addison74
Copy link

We have to appreciate the fact that @derickr responded very quickly today to our reports and solved the issue. But since we are warned not to use timezone formats such as GMT-n or GMT+n, ZF1-Future must be updated too, especially since it has meanwhile become an important piece for the OpenMage project.

@glensc
Copy link
Collaborator

glensc commented Jan 11, 2023

@elidrissidev
Copy link
Author

Yes I know but that issue got closed already. PHP will fix this in the next version, but I'm wondering if something can be done about it to replace those timezones with the appropriate ones.

@addison74
Copy link

I quote the observation made by @sreichel in the OpenMage repository:

"ZF1 uses this file https://github.com/unicode-org/cldr/blob/main/common/supplemental/windowsZones.xml"

@sreichel
Copy link

i think playing around with the file doesn't make sense. rather wait for the next release and avoid 8.1.4/8.2.1?

@hungtrinh
Copy link

hungtrinh commented Feb 15, 2023

@elidrissidev
Copy link
Author

Although it has been reported that the bug was resolved in the upcoming PHP version, it still would be good to address this issue to avoid any potential problems in the future. But I'm still not sure how to address this.

@Shardj Shardj closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants