-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicDataSharedDepth undefined in hosted workbench (SPFx 1.8.1) #3820
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Just to clarify. The local workbench is the one served from localhost, the hosted workbench is the one in SPO. Is it the local workbench that is failing? |
@patmill no, it is the hosted one that fails. The local one AND the SharePoint pages work without issues. |
So that's certainly strange. DynamicDataSharedDepth is undefined? That's an enum... What package are you importing it from? Can you make sure that it is sp-property-pane? |
I tried both the old one (SP-webpart-base) and the new one (SP-property-pane), both resulting in the same behavior locally (works) and hosted (doesn’t work). |
OK, so it is only 1.8.1 that does this, not 1.8.0. digging in more. |
OK - figured it out. A seemingly innocuous change. We will work on getting a proper fix rolled out, and you won't need to modify your code. In the meantime, if you want to work around this, use a hard coded value (0,1,2) rather than the enum. |
Thank you for figuring it out! I’ll wait for the fix to roll out, it isn’t that pressing. |
This is fixed in my environments, so I'm closing this! |
Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues |
Category
Expected or Desired Behavior
When running an SPFx 1.8.1 solution that uses Dynamic Data with 'gulp serve', I expect it to work correctly in the local workbench, the hosted workbench and SharePoint pages.
Observed Behavior
Running the solution works without an issue in the local workbench and SharePoint pages, but in the hosted workbench it throws the following exception: "Cannot read property 'Source' of undefined". Issues occurs with
DynamicDataSharedDepth.Source
The error doesn't occur when using SPFx 1.7.1. It starts occurring when I upgraded the solution to 1.8.1 with the guidance from the Office 365 CLI and only when opening the Property Pane.
Also occurs in a newly created solution. Tested on 3 different tenants, with Google Chrome.
Steps to Reproduce
The text was updated successfully, but these errors were encountered: