Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for preview web apps #122

Open
Jonas-Sander opened this issue Feb 6, 2022 · 2 comments
Open

Add a warning for preview web apps #122

Jonas-Sander opened this issue Feb 6, 2022 · 2 comments
Labels
good first issue This issue is good for new contributors. Easy to fix. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. ui / ux

Comments

@Jonas-Sander
Copy link
Collaborator

I think we should also add a warning in the future that its a temporary web app and that no personal data should be entered - like #27

Originally posted by @Jonas-Sander in #119 (comment)
@Jonas-Sander Jonas-Sander added ui / ux legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. labels Feb 6, 2022
@nilsreichardt
Copy link
Member

I think we do this with Dart environment variables. In the code, we can just use bool.fromEnvironment('STAGE') (if is equal to preview, show warning) and pass the stage via the build command flutter build web --release --dart-define STAGE="preview". Or do you have a different approach?

@Jonas-Sander
Copy link
Collaborator Author

Sounds good, I would maybe define it as DEPLOYMENT_STAGE instead of just STAGE

@nilsreichardt nilsreichardt added the good first issue This issue is good for new contributors. Easy to fix. label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is good for new contributors. Easy to fix. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. ui / ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nilsreichardt @Jonas-Sander