Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split web-preview up into pull_request and workflow_run. #562

Open
Jonas-Sander opened this issue Apr 5, 2023 · 0 comments
Open

Split web-preview up into pull_request and workflow_run. #562

Jonas-Sander opened this issue Apr 5, 2023 · 0 comments

Comments

@Jonas-Sander
Copy link
Collaborator

Split the workflow into building the code for web via a pull_request trigger, upload the artifact and run a second action on success via the workflow_run trigger, which will upload the builded code to Firebase Hosting. This would seperate building the untrusted code (dangerous) and uploading the code that was just build (not dangerous - hopefully 😉).
The second Action will have access to the secrets, since it is triggered on workflow_run, not pull_request.
This approach is described in more details with examples here.

Copied from #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant