From 7c5fd6ab86908abf22b101fcb36daf05e9a7f796 Mon Sep 17 00:00:00 2001 From: Jonas Sander <29028262+Jonas-Sander@users.noreply.github.com> Date: Thu, 25 Jul 2024 13:16:32 +0200 Subject: [PATCH 1/2] Use adaptive platform density for privacy policy. --- .../legal/privacy_policy/privacy_policy_page.dart | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/lib/legal/privacy_policy/privacy_policy_page.dart b/app/lib/legal/privacy_policy/privacy_policy_page.dart index c965f509a..084422f9a 100644 --- a/app/lib/legal/privacy_policy/privacy_policy_page.dart +++ b/app/lib/legal/privacy_policy/privacy_policy_page.dart @@ -52,8 +52,19 @@ class PrivacyPolicyPage extends StatelessWidget { create: (context) { final themeSettings = Provider.of(context, listen: false); - return _createPrivacyPolicyThemeSettings( + final newSettings = _createPrivacyPolicyThemeSettings( context, themeSettings, config); + // As of writing this we always use + // VisualDensitySetting.standard() instead of + // VisualDensitySetting.adaptivePlatformDensity() on all + // platforms. This might sense for the general UI, but + // for the privacy policy page it is way better use the adaptive + // spacing. This will make the TOC tiles to be more compact for + // desktop (since users will most probably use a mouse there) + // and more spaced out for users using touch. + newSettings.visualDensitySetting = + VisualDensitySetting.adaptivePlatformDensity(); + return newSettings; }, ), Provider( From 4abc1cb0bcdffd74686ffbda7e7b53f42097401d Mon Sep 17 00:00:00 2001 From: Jonas Sander <29028262+Jonas-Sander@users.noreply.github.com> Date: Thu, 25 Jul 2024 16:25:34 +0200 Subject: [PATCH 2/2] Update app/lib/legal/privacy_policy/privacy_policy_page.dart Co-authored-by: Nils Reichardt --- .../legal/privacy_policy/privacy_policy_page.dart | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/lib/legal/privacy_policy/privacy_policy_page.dart b/app/lib/legal/privacy_policy/privacy_policy_page.dart index 084422f9a..f71ea5455 100644 --- a/app/lib/legal/privacy_policy/privacy_policy_page.dart +++ b/app/lib/legal/privacy_policy/privacy_policy_page.dart @@ -54,14 +54,14 @@ class PrivacyPolicyPage extends StatelessWidget { Provider.of(context, listen: false); final newSettings = _createPrivacyPolicyThemeSettings( context, themeSettings, config); - // As of writing this we always use + // As of this writing, we always use // VisualDensitySetting.standard() instead of // VisualDensitySetting.adaptivePlatformDensity() on all - // platforms. This might sense for the general UI, but - // for the privacy policy page it is way better use the adaptive - // spacing. This will make the TOC tiles to be more compact for - // desktop (since users will most probably use a mouse there) - // and more spaced out for users using touch. + // platforms. This may make sense for the general UI, but for + // the privacy policy page it is much better to use the adaptive + // spacing. This will make the TOC tiles more compact for + // desktop (since users will most likely be using a mouse there) + // and more spread out for touch users. newSettings.visualDensitySetting = VisualDensitySetting.adaptivePlatformDensity(); return newSettings;