Trade Post Remake troi #3367
Trade Post Remake troi #3367
Conversation
github-actions
bot
added
Map Change
|
|
||
| //inteq | ||
|
|
||
| /obj/effect/mob_spawn/human/corpse/inteq |
There was a problem hiding this comment.
I don't really want stocked corpses in a ruin like this.
There was a problem hiding this comment.
what would you suggest trimming it down to?
| "conc_tiles" | ||
| )) | ||
|
|
||
| /turf/open/floor/concrete/wasteplanet/MakeSlippery(wet_setting, min_wet_time, wet_time_to_add, max_wet_time, permanent) |
There was a problem hiding this comment.
why is specifically wasteplanet concreate not slippery
There was a problem hiding this comment.
wasteplanets can spawn with water vapor in the atmosphere (unless this has been changed. I did not check), and having a biome turn into a giant slip and slide doesn't sound like an engaging gameplay experience.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
|
hey can you fix your checks |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
There was a problem hiding this comment.
Feedback after testing on live:
The main office building is exposed to the waste planet atmos. Either give it a proper door or replace the tiles inside with tile subtypes with planet atmos.
There's not really much in these rooms to justify them being bolted, and consequently being worth the effort to break inside. I feel it would good to add some kind of minor loot or money in the office.
The paths are fairly plain looking. I think they would benefit from some decals or siding.
There's a normal NT Commander here instead of an Inteq Commissioner here. You can cut this one since there's already two other commissioners to loot.
.
I'd suggest swapping the position of the mongrel with one of the commissioners. From a flavor standpoint it makes more sense for it be near it's mags, and players have to go through a bit more effort to get the stronger gun.
Players had some confusion on whether the Tradepost was fully Inteq owned. If they were contracted, I think it would be good to add some civilian corpses around the base.
The outer area of the ruin is very dark for what was supposed to be an inhabited area. There's only a single broken floodlight for what would have been a cargo port. I'd suggest scattering around some more broken or maybe even a few working lights on the exterior of the buildings.
As for the Inteq corpses, you could make a subtype of the outfits for use in the ruin with some of their gear cut. The main concerns to me are the corpsman and the vanguard. The corpsman comes with a loaded webbing, so you can either cut it or give them an empty one. Cut the gear from the Vanguard corpse's pockets, and the telebaton in their backpack.
|
addressed review (aside from the roads. idk how to get a nice decal pattern on those and think that the plain is somewhat alright) |
Gristlebee
dismissed stale reviews from meemofcourse and thgvr
Outdated, gear has been cut down.
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Remasters the currently removed and unpersoned wasteplanet tradepost map. You have never seen this pr before.    <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game A 'new' ruin of decent quality and some more mapgen options should enrich the experience. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: Erika Fox add: An abandoned tradepost has been located in the system. Investigate nearby waste worlds for more information. add: preburnt flares /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Erika Fox <[email protected]> Signed-off-by: Erika Fox <[email protected]> Co-authored-by: Erika Fox <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Remasters the currently removed and unpersoned wasteplanet tradepost map. You have never seen this pr before.    <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game A 'new' ruin of decent quality and some more mapgen options should enrich the experience. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: Erika Fox add: An abandoned tradepost has been located in the system. Investigate nearby waste worlds for more information. add: preburnt flares /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Erika Fox <[email protected]> Signed-off-by: Erika Fox <[email protected]> Co-authored-by: Erika Fox <[email protected]>
About The Pull Request
Remasters the currently removed and unpersoned wasteplanet tradepost map. You have never seen this pr before.
Why It's Good For The Game
A 'new' ruin of decent quality and some more mapgen options should enrich the experience.
Changelog
🆑 Erika Fox
add: An abandoned tradepost has been located in the system. Investigate nearby waste worlds for more information.
add: preburnt flares
/:cl: