-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ammo Antics #3694
Ammo Antics #3694
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
I wonder how viable it would be to make the speed values you defined here modifiers on the cartridge’s base speed value rather than fixed values? I was looking over the code and noticed a few weird things here and there like match revolver bullets being faster than standard DMR bullets. it’d be nice if we could make certain guns in general have slightly faster or slower bullets than others while still having the cleaner, lower-maintenance code you made here for the cartridges |
we'd have to tie it to a modifier like how bullet skins work. not opposed to doing it like such, though. |
A few select bullet types like .22lr hollow / rubber and .300 are half and half normal. Probably a quick fix but something you might wanna look at before We Become Real |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
6.5x57mm only has half the ammo and its the wrong ammo type for both normal and trackers. |
code/modules/projectiles/boxes_magazines/ammo_stacks/prefab_stacks/premade_sniper_stacks.dm
Outdated
Show resolved
Hide resolved
…acks/premade_sniper_stacks.dm Signed-off-by: Erika Fox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document cruft removals in changelog
code/modules/projectiles/boxes_magazines/ammo_stacks/prefab_stacks/premade_smg_stacks.dm
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Erika Fox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
yaaaaay |
Subtypes AP/HP/Rubber ammo for several calibres that didn't have it. adds it to the market in relevant cases. adds tracker rounds to a few places. makes them work differently. removes incendiary ammo from everything except shotguns - [ ] I tested my pr makes the ammo gameplay stuff available to more weapons. entertainment value :cl: add: rifle calibre and pdw calibre rubbershot/armor piercing/hollow point. check da outpost add: tracker rounds for a few guns. check the black market :3 del: most forms of incendiary ammo del: A bunch of clown and mime stuff tangentially related to guns /:cl: --------- Signed-off-by: Erika Fox <[email protected]> Co-authored-by: Bjarl <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
About The Pull Request
Subtypes AP/HP/Rubber ammo for several calibres that didn't have it. adds it to the market in relevant cases.
adds tracker rounds to a few places. makes them work differently.
removes incendiary ammo from everything except shotguns
Why It's Good For The Game
makes the ammo gameplay stuff available to more weapons. entertainment value
Changelog
🆑
add: rifle calibre and pdw calibre rubbershot/armor piercing/hollow point. check da outpost
add: tracker rounds for a few guns. check the black market :3
del: most forms of incendiary ammo
del: A bunch of clown and mime stuff tangentially related to guns
/:cl: