From 4320db1fb5087571ef80a8f8a0f270dddf1eec37 Mon Sep 17 00:00:00 2001 From: Sagar Khalasi Date: Mon, 9 Sep 2024 11:55:00 +0530 Subject: [PATCH] fix: Video2 spec flaky fix (#36166) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description RCA: We are using youtube url for `Verify Basic Functionality of Video Widget - muted`. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case. Solution: Deleted this test as it can be part of manual testing. Fixes #`36164` ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 11d8d952f5e24cc49056532b15da190eefe8ba41 > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Mon, 09 Sep 2024 05:41:15 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **Bug Fixes** - Removed a test case for the muted functionality of the Video Widget, streamlining the test suite. - **Chores** - Updated the test path in the limited-tests file to prioritize video widget testing over template testing. --- .../ClientSide/Widgets/Video/Video2_Spec.ts | 37 +++---------------- 1 file changed, 5 insertions(+), 32 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts index 6490f5c8af53..55ab1a650cd0 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts @@ -49,34 +49,7 @@ describe( agHelper.AssertProperty(widgetLocators.video, "ended", true); }); - it("2. Verify Basic Functionality of Video Widget - muted", function () { - deployMode.NavigateBacktoEditor(); - EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); - //Validate video for youtube url - propPane.TypeTextIntoField("URL", testdata.videoUrl); - deployMode.DeployApp(locators._widgetInDeployed(draggableWidgets.VIDEO)); - agHelper.GetNClick(locators._widgetInDeployed(draggableWidgets.VIDEO)); - agHelper.Sleep(2000); - agHelper.GetElement(widgetLocators.iFrame).then(($iframe) => { - const doc = $iframe.contents(); - const video = doc.find(widgetLocators.video); - //Check play, mute & unmute, volume buttons - cy.wrap( - doc.find(widgetLocators.videoWidgetYoutubeLargePlayBtn), - ).click(); - cy.wrap(video).click(); - agHelper.Sleep(1000); - cy.wrap(doc.find(widgetLocators.videoWidgetYoutubeMuteBtn)).click(); - agHelper.AssertProperty(video, "muted", true); - agHelper.AssertProperty(video, "paused", true); - cy.wrap(doc.find(widgetLocators.videoWidgetYoutubeVolumeBtn)).type( - "{rightarrow}{rightarrow}", - ); - agHelper.AssertProperty(video, "muted", false); - }); - }); - - it("3. Verify widget for invalid URL's", function () { + it("2. Verify widget for invalid URL's", function () { deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); propPane.RemoveText("URL"); @@ -107,7 +80,7 @@ describe( }); }); - it("4. Verify auto play property", function () { + it("3. Verify auto play property", function () { deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); agHelper.AssertExistingToggleState("Autoplay", "false"); @@ -128,7 +101,7 @@ describe( agHelper.AssertProperty(widgetLocators.video, "paused", true); }); - it("5. Verify visible property", function () { + it("4. Verify visible property", function () { deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); agHelper.AssertExistingToggleState("Visible", "true"); @@ -154,7 +127,7 @@ describe( ); }); - it("6. Verify OnPlay, OnPause, OnEnd events are JS convertible", function () { + it("5. Verify OnPlay, OnPause, OnEnd events are JS convertible", function () { deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); propPane.EnterJSContext( @@ -193,7 +166,7 @@ describe( }); }); - it("7. Verify video styles", function () { + it("6. Verify video styles", function () { deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Video1", EntityType.Widget); propPane.MoveToTab("Style");