Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rustfmt to the codebase #48

Closed
Delapouite opened this issue Jan 19, 2023 · 1 comment
Closed

Apply rustfmt to the codebase #48

Delapouite opened this issue Jan 19, 2023 · 1 comment

Comments

@Delapouite
Copy link

Hello.

While I was skimming through the codebase through github.com, I was surprised to stumble upon very weirdly indented code which was very hard to follow :

Here's an example take from item.rs :

image

Indeed, after git cloning the repo on my local station, it turns out that the source code uses a mixed bag for spaces and tabs, so the problem remain in my text-editor.

I reckon it could be worthwhile to perform some cleanup with rustfmt across all rust files in order to alleviate the problem.

Thanks.

@Shizcow
Copy link
Owner

Shizcow commented Aug 9, 2023

I've added make fmt which does the pre-requisite setup and then calls rustfmt. Unfortunately due to how the build system is set up, adding a github action to do this is not easily possible.

@Shizcow Shizcow closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants