Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of set*() global setters in Hydrogen framework #1043

Closed
jplhomer opened this issue Apr 5, 2022 · 1 comment
Closed

Get rid of set*() global setters in Hydrogen framework #1043

jplhomer opened this issue Apr 5, 2022 · 1 comment
Labels
framework Related to framework aspects of Hydrogen

Comments

@jplhomer
Copy link
Contributor

jplhomer commented Apr 5, 2022

Attach them to request.ctx instead, and access it with useServerContext.

Found in entry-server.tsx.
@jplhomer jplhomer added the framework Related to framework aspects of Hydrogen label Apr 19, 2022
@jplhomer jplhomer mentioned this issue Jun 2, 2022
Merged
4 tasks
@jplhomer
Copy link
Contributor Author

jplhomer commented Jun 2, 2022

Calling this done since #1422 shipped, and we can still keep the global cache reference around for use outside of the React lifecycle.

@jplhomer jplhomer closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework Related to framework aspects of Hydrogen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jplhomer