Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Router scrolls to top whenever server state is finished being updated. #810

Closed
nattyg93 opened this issue Mar 4, 2022 · 0 comments · Fixed by #813
Closed

[BUG] Router scrolls to top whenever server state is finished being updated. #810

nattyg93 opened this issue Mar 4, 2022 · 0 comments · Fixed by #813
Labels
bug Something isn't working

Comments

@nattyg93
Copy link

nattyg93 commented Mar 4, 2022

Describe the bug
The router will scroll to the top of the page whenever the server state is finished being updated.

To Reproduce

  1. Go to the collections page
  2. Scroll down and click the "load more" button
  3. Note the screen scrolls to the top despite there being no navigation event

Expected behaviour
The client router should only scroll to the top when an actual navigation event occurs rather than any time the server state is updated.

Additional context

  • Hydrogen version: v0.11.1
  • Node version: v16.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not scroll to top if the URL pathname has not changed Shopify/hydrogen-v1
1 participant
@nattyg93