Add better evicted cart support #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
changed the title
juanpprieto
approved these changes
Dec 16, 2022
frandiox
approved these changes
Jan 3, 2023
Comment on lines
+151
to
+155
| /** | ||
| * The Cart ID may change after each mutation. We need to update it each time in the session. | ||
| */ | ||
| session.set('cartId', cartId); | ||
| headers.set('Set-Cookie', await session.commit()); |
There was a problem hiding this comment.
Should we wrap this in if (storedCartId !== cartId)?
There was a problem hiding this comment.
We probably could, but committing it every time is simpler and one less thing to reason about.
Co-authored-by: Fran Dios <[email protected]>
cartogram
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #325, we attempted to solve an issue that exists today in the SFAPI Cart implementation: carts will be "evicted" from storage after X days of inactivity.
However, as discussed here:https://github.com/Shopify/core-issues/issues/48930 that would be solving the problem at the wrong layer. Clients like Hydrogen should not be concerned about this implementation detail.
Instead, the Cart API will be updated to "soft-404" for mutations against an evicted cart, and return a new Cart ID instead.
This PR:
cartIdis updated in the session after each mutation