From dd232ff93f174dab239c6ab11542e0b44ad66e12 Mon Sep 17 00:00:00 2001 From: Gleb Glazov Date: Sun, 11 Oct 2020 19:32:24 +0300 Subject: [PATCH 1/2] [DEV] Fixing double logging of cache hits and misses --- lib/identity_cache/memoized_cache_proxy.rb | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/identity_cache/memoized_cache_proxy.rb b/lib/identity_cache/memoized_cache_proxy.rb index 6e679d1d..a6ce99ac 100644 --- a/lib/identity_cache/memoized_cache_proxy.rb +++ b/lib/identity_cache/memoized_cache_proxy.rb @@ -195,15 +195,15 @@ def memoizing? end def log_multi_result(keys, memo_miss_keys, cache_miss_keys) - IdentityCache.logger.debug do - memoized_keys = keys - memo_miss_keys - cache_hit_keys = memo_miss_keys - cache_miss_keys - missed_keys = cache_miss_keys - - memoized_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] (memoized) cache hit for #{k} (multi)") } - cache_hit_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] (backend) cache hit for #{k} (multi)") } - missed_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] cache miss for #{k} (multi)") } - end + return unless IdentityCache.logger.level == Logger::DEBUG + + memoized_keys = keys - memo_miss_keys + cache_hit_keys = memo_miss_keys - cache_miss_keys + missed_keys = cache_miss_keys + + memoized_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] (memoized) cache hit for #{k} (multi)") } + cache_hit_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] (backend) cache hit for #{k} (multi)") } + missed_keys.each { |k| IdentityCache.logger.debug("[IdentityCache] cache miss for #{k} (multi)") } end end end From d8d5b03b0bedae325c25f94fd61d28cb331b8bee Mon Sep 17 00:00:00 2001 From: Dylan Thacker-Smith Date: Fri, 8 Jan 2021 14:37:47 -0500 Subject: [PATCH 2/2] Use Logger#debug? instead of doing a debug level equality comparison --- lib/identity_cache/memoized_cache_proxy.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/identity_cache/memoized_cache_proxy.rb b/lib/identity_cache/memoized_cache_proxy.rb index a6ce99ac..743e67a9 100644 --- a/lib/identity_cache/memoized_cache_proxy.rb +++ b/lib/identity_cache/memoized_cache_proxy.rb @@ -195,7 +195,7 @@ def memoizing? end def log_multi_result(keys, memo_miss_keys, cache_miss_keys) - return unless IdentityCache.logger.level == Logger::DEBUG + return unless IdentityCache.logger.debug? memoized_keys = keys - memo_miss_keys cache_hit_keys = memo_miss_keys - cache_miss_keys