From 3983507a43a0f52d628e722b69df58ba7c0ae9ee Mon Sep 17 00:00:00 2001
From: Dylan Thacker-Smith <Dylan.Smith@shopify.com>
Date: Fri, 3 Apr 2020 16:21:44 -0400
Subject: [PATCH] Refactor IdentityCache::Cached::Reference::HasOne for
 consistency

Also, avoids the redundant association lookup
---
 lib/identity_cache/cached/reference/has_one.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/identity_cache/cached/reference/has_one.rb b/lib/identity_cache/cached/reference/has_one.rb
index 6db82e79..160549f4 100644
--- a/lib/identity_cache/cached/reference/has_one.rb
+++ b/lib/identity_cache/cached/reference/has_one.rb
@@ -21,8 +21,8 @@ def #{cached_id_name}
             end
 
             def #{cached_accessor_name}
-              association_klass = association(:#{name}).klass
-              if association_klass.should_use_cache? && !association(:#{name}).loaded?
+              assoc = association(:#{name})
+              if assoc.klass.should_use_cache? && !assoc.loaded?
                 #{records_variable_name} ||= #{reflection.class_name}.fetch(#{cached_id_name}) if #{cached_id_name}
               else
                 #{name}