Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dalli integration #462

Closed
saiqulhaq opened this issue May 12, 2020 · 2 comments
Closed

Dalli integration #462

saiqulhaq opened this issue May 12, 2020 · 2 comments

Comments

@saiqulhaq
Copy link

on the readme, it says we have to use memcached_store. however I found that Dalli also has CAS support. what should we do to make Dalli can work with Identity Cache gem?

@dylanahsmith
Copy link
Contributor

It doesn't look like active support's ActiveSupport::Cache::MemCacheStore provides CAS support or exposes the underlying Dalli::Client instance, so I think we need to add CAS support to active support if we want to integrate with ActiveSupport::Cache::MemCacheStore.

Alternatively, we can provide a cache adapter that integrates with a Dalli::Client instance directly. The cache adapter will be used by IdentityCache::CacheFetcher if it provides cas and cas_multi methods that behave like those provided by the memcached_store gem. In addition to those methods, it will also need to provide a write method that behaves like ActiveSupport::Cache::Store.

@saiqulhaq
Copy link
Author

#465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants